Change single udp config to support multiple UDP listeners #3599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…listeners do not use NewConfig for UDP appendUDPService must return a value udp service does not need to handle error fix missing case of c.UDP in tests
|
Would it be preferable to retain |
|
This seems to me to be a worthwhile change -- thanks @tpitale. Have you signed the CLA? This is a breaking change, as you say, so we'll need to decide how best to handle it. |
tpitale
changed the title
|
+1. |
|
Confirmed CLA has been signed. |
|
👍 |
otoolep
added a commit
that referenced
this pull request
Aug 10, 2015
Change single udp config to support multiple UDP listeners
|
Thanks @tpitale |
otoolep
added a commit
that referenced
this pull request
Aug 10, 2015
…rvers"" This reverts commit 5f83f03.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3596
In 0.7.1 multiple udp listeners could be configured. I upgraded to 0.9.2 and this feature appeared to be missing. This, hopefully, adds it back.
It does replace the single TOML configuration for
[udp]with[[udp]]. I'm not sure if/how this should be handled. This may be considered a breaking change, but since the ability to use multiple servers was already lost (a breaking change) … this seems reasonable to add back in.