Implement fill(mean) #3394
Closed
Implement fill(mean) #3394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdf
force-pushed
the
gh_3273
branch
2 times, most recently
from
6d54f68 to
e86e36b
Compare
| current := int64toFloat64(vals[j]) | ||
| var count int | ||
| if nullFirst { | ||
| count = i |
There was a problem hiding this comment.
So, I'm not really certain if extrapolating the data back to the start like this is a good idea, or whether we should just leave the start of the series with nulls.
|
@pdf -- our query engine has undergone significant refactoring for the 0.9.2 release. Can you rebase this change? |
|
I'm not sure this is actually useful due to the order that fills are applied. |
|
@pdf -- our code has changed significantly since this PR due to the new engines and performance improvements. This will need to be re-implemented if you want to get it in. |
|
@otoolep consider this abandoned, unless I roll around to InfluxDB again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3273