-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow WAL inter-flush delay to be configurable #3217
Conversation
### | ||
|
||
[data] | ||
dir = "/var/opt/influxdb/data" | ||
MaxWALSize = 104857600 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need comments for each of the following lines describing what they are and what the value is
b20343e
to
8c51ebf
Compare
Will cherry-pick to 0.9.1 after merge to master. |
+1 |
2 similar comments
+1 |
+1 |
Allow WAL inter-flush delay to be configurable
Is it possible to also configure the WAL flush interval timer? What if a WAL flush cannot complete in <10 minutes? Can it default to 10 minutes, and be configurable to accommodate less capable hardware, without falling behind? |
@ecables: It's configurable: https://github.com/influxdb/influxdb/blob/master/etc/config.sample.toml#L40 The 10 minutes is more about making sure that shards that are cold for writes eventually get flushed. It's also about making sure that if you have series that have a 10s sampling interval, enough points are grouped into each series to make the flush efficient. It doesn't improve performance at all if you're writing to many series and you flush the wall so frequently that when it happens you only have a single point per series. |
Perfect; thanks for the explanation. |
This increases the inter-flush delay to a default of 2 seconds, and also makes it configurable.
#3215