-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Processing some queries in batches and new EXPLAIN command #318
Conversation
@@ -19,6 +19,10 @@ import ( | |||
"time" | |||
) | |||
|
|||
const ( | |||
POINT_BATCH_SIZE = 256 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be great to move this into a configuration option as you mentioned before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added it.
It is now point-batch-size under [leveldb] section in config.toml
Thanks @elcct for your contribution. We're really excited about the new features that you added in this pull request. Couple of things that will make it extremely easy for us to merge your changes in the future (I'll put these guidelines in a commiters readme file):
If you have any questions or comments feel free to tell us. Cheers, |
Thank you. I am sorry for the trouble, next time I will follow those guidelines. |
I merged my branch which included some tests and bug fixes. I encourage you to take a look and verify that I didn't do something stupid. doing Thanks again for your contribution. |
Great, i should take a look during the weekend. |
See my comments for #294 and #263