Copy an Batch tags to each point before marshalling #3131
Conversation
| @@ -124,11 +124,15 @@ func (c *Client) Write(bp BatchPoints) (*Response, error) { | |||
|
|
|||
| var b bytes.Buffer | |||
| for _, p := range bp.Points { | |||
| if p.Raw != "" { | |||
| if p.Raw != "" && len(bp.Tags) == 0 { | |||
There was a problem hiding this comment.
Not exactly sure what Raw is but I think Raw and BatchPoints.Tags can't really be used together unless we parse the Raw value and add the tags to it. If you set Raw and have BatchPoints.Tags, I believe the write will fail because the Raw value will not be marshaled... only the BatchPoints.Tags.
Is that intended by this line?
There was a problem hiding this comment.
Ah, no, it wasn't. I figured Raw was there if the Point had previously been marshaled here and the other data was also available. If it's the case that Raw might be the only thing set, we could either ignore BatchPoint.Tags or parse and re-emit.
There was a problem hiding this comment.
Can you remove that line?
Seems a different fix for Raw lines is needed and I'm not sure that the client should really have a Raw field to begin with.
|
@jwilder ok, I removed the check added to the |
|
👍 |
Copy an Batch tags to each point before marshalling
This is to fix influxdata/telegraf#18. The switch away from JSON to the line protocol broke passing the tags specified in BatchPoints.