Add support for marshaling uint64 in client.
#3033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddboom
force-pushed
the
client-marshal-uint64
branch
from
deab216 to
729bdec
Compare
|
Seems sane. On Wednesday, June 17, 2015, Todd Persen notifications@github.com wrote:
|
| @@ -923,6 +923,8 @@ func (p Fields) MarshalBinary() []byte { | |||
| b = append(b, []byte(strconv.FormatInt(int64(t), 10))...) | |||
| case int32: | |||
| b = append(b, []byte(strconv.FormatInt(int64(t), 10))...) | |||
| case uint64: | |||
| b = append(b, []byte(strconv.FormatInt(int64(t), 10))...) | |||
There was a problem hiding this comment.
Using strconv.FormatUint() will avoid a type conversion.
toddboom
force-pushed
the
client-marshal-uint64
branch
from
729bdec to
b625286
Compare
toddboom
added a commit
that referenced
this pull request
Jun 18, 2015
Add support for marshaling `uint64` in client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spotted this when testing out Telegraf. I don't see any reason it shouldn't get handled here.