Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic during wildcard expansion if no database specified #2994

Merged
merged 3 commits into from
Jun 15, 2015

Conversation

otoolep
Copy link
Contributor

@otoolep otoolep commented Jun 15, 2015

Statements were only being normalized if a default database was included
in the query (usually via the query param 'db'). However if no default
database was included, and none was an explicit part of the measurement
name, no database-existence check was run. This results in a later panic
with wildcard expansion.

Fixes #2932

It is not used by the code -- the database on the measurement object
that determines the target database.
@otoolep otoolep force-pushed the panic_no_db_in_url branch from 1731897 to 461cccc Compare June 15, 2015 18:46
@otoolep otoolep changed the title Fix panic during wilcard expanion if no database specified Fix panic during wildcard expanion if no database specified Jun 15, 2015
@otoolep otoolep changed the title Fix panic during wildcard expanion if no database specified Fix panic during wildcard expansion if no database specified Jun 15, 2015
@otoolep
Copy link
Contributor Author

otoolep commented Jun 15, 2015

@dgnorton @corylanou

otoolep added 2 commits June 15, 2015 11:51
Statements were only being normalized if a default database was included
in the query (usually via the query param 'db'). However if no default
database was included, and none was an explicit part of the measurement
name, no database-existence check was run. This result in a later panic
with wildcard expansion.
@otoolep otoolep force-pushed the panic_no_db_in_url branch from 461cccc to b758a23 Compare June 15, 2015 18:51
@dgnorton
Copy link
Contributor

+1

otoolep added a commit that referenced this pull request Jun 15, 2015
Fix panic during wildcard expansion if no database specified
@otoolep otoolep merged commit 96aaba3 into master Jun 15, 2015
@otoolep otoolep deleted the panic_no_db_in_url branch June 15, 2015 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants