Export WaitForLeader on MetaStore #2931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otoolep
force-pushed
the
wait_for_leader
branch
2 times, most recently
from
67654ec to
e91c34c
Compare
This exported function can then be used by Services and server-reporting, so those components don't make progress until the cluster is ready.
|
Green build. |
|
Would it work to |
|
@dgnorton -- I thought about that, but not all services might want to wait. I thought it was best to leave it on a service-by-service basis. |
| // waitForLeader sleeps until a leader is found or a timeout occurs. | ||
| func (s *Store) waitForLeader(timeout time.Duration) error { | ||
| // WaitForLeader sleeps until a leader is found or a timeout occurs. | ||
| func (s *Store) WaitForLeader(timeout time.Duration) error { | ||
| // Begin timeout timer. | ||
| timer := time.NewTimer(timeout) |
There was a problem hiding this comment.
Probably should check to see if there's already a leader before starting a polling loop.
There was a problem hiding this comment.
Good point, pushed up a change.
|
+1 on green |
|
👍 |
otoolep
added a commit
that referenced
this pull request
Jun 11, 2015
Export WaitForLeader on MetaStore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exported function can then be used by Services and
server-reporting, so those components don't make progress until the
cluster is ready.