Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable server reporting #2904

Merged
merged 6 commits into from
Jun 11, 2015
Merged

Re-enable server reporting #2904

merged 6 commits into from
Jun 11, 2015

Conversation

otoolep
Copy link
Contributor

@otoolep otoolep commented Jun 11, 2015

No description provided.

@toddboom
Copy link
Contributor

yeah, this looks awesome. much simpler than what i had started.

@otoolep
Copy link
Contributor Author

otoolep commented Jun 11, 2015

Yeah, I think a Service is overkill for this.

@otoolep otoolep force-pushed the reporter_service branch from b7a667a to bcf4bf0 Compare June 11, 2015 05:35
@@ -46,6 +46,15 @@ func (d *DatabaseIndex) Measurement(name string) *Measurement {
return d.measurements[name]
}

// MeasurementSeriesCounts returns the number of measurments and series currently indexed by the database.
// Useful for reporting and monitoring.
func (d *DatabaseIndex) MeasurementSeriesCounts() (nMeasurements int, nSeries int) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Named return values, for self-documentation purposes.

@toddboom
Copy link
Contributor

+1

@otoolep otoolep force-pushed the reporter_service branch 2 times, most recently from d7c1692 to 2b5e7f4 Compare June 11, 2015 07:13
@pauldix
Copy link
Member

pauldix commented Jun 11, 2015

LGTM 🚢

@otoolep otoolep force-pushed the reporter_service branch from 2b5e7f4 to 923556d Compare June 11, 2015 07:20
@otoolep otoolep force-pushed the reporter_service branch from 923556d to 9681f4b Compare June 11, 2015 07:22
otoolep added a commit that referenced this pull request Jun 11, 2015
@otoolep otoolep merged commit c644b33 into master Jun 11, 2015
@otoolep otoolep deleted the reporter_service branch June 11, 2015 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants