-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert OpenTSDB to service #2823
Conversation
if p.Time < 10000000000 { | ||
ts = time.Unix(p.Time, 0) | ||
} else { | ||
ts = time.Unix(p.Time/1000, (p.Time%1000)*1000) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming we are converting to ms here? But a comment to clarify would be helpful.
+1 on green build. |
I also reviewed this code, particularly to see if it had implications for #2799. The WaitGroup handling here seems OK, so +1 from me. |
Obviously +1 on a green build, as per @corylanou |
37006dc
to
2e3d5f2
Compare
I don't where the PointsWriter is supplied to this service, by the production code. |
if err := h.PointsWriter.WritePoints(&cluster.WritePointsRequest{ | ||
Database: h.Database, | ||
RetentionPolicy: h.RetentionPolicy, | ||
ConsistencyLevel: cluster.ConsistencyLevelOne, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks hardcoded. Does this mean clients will have no control over consistency level with openTSDB?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just want to convert the old server over to a service right now. We can add consistency level separately.
This commit converts the OpenTSDB endpoint into a service.
OK, let's get it in. Thanks for the final changes. |
Convert OpenTSDB to service
Overview
This pull request converts the OpenTSDB server into a service and adds some tests.