Time literals should use single quotes in String representation #2804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@beckettsean, @dgnorton -- any comment? |
|
+1 from me. Timestamps as strings should be in single-quotes to be consistent with strings elsewhere. Double-quotes should only be for identifiers. |
|
Yep, agree. Thanks! |
pauldix
added a commit
that referenced
this pull request
Jun 11, 2015
Time literals should use single quotes in String representation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using the influxql package to parse an generic query and add a specific time clause to the query. Since a TimeLiteral needs single quotes when parsed I have updated the String representation to also use single quotes as well as the test cases.