Include client timeout configuration #2684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladlopes
force-pushed
the
include-client-timeout
branch
from
ca11173 to
3e03be3
Compare
|
@vladlopes this looks good - would you mind rebasing? we'll try to get this released with RC32 later today. |
| @@ -23,11 +23,13 @@ type Query struct { | |||
| // URL: The URL of the server connecting to. | |||
| // Username/Password are optional. They will be passed via basic auth if provided. | |||
| // UserAgent: If not provided, will default "InfluxDBClient", | |||
| //Timeout: If not provided, will default to 0 (no timeout) | |||
There was a problem hiding this comment.
Nit: whitespace before the letter 'T'.
|
+1 |
|
@vladlopes i went ahead and fixed the spacing and the merge conflict (it was just from the CHANGELOG), so this is in. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client had no way to configure its Timeout.