Wait for quorum write before returning from Log.Apply(). #2566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -341,9 +341,10 @@ func (c *Client) do(method, path string, values url.Values, contentType string, | |||
| // If a temporary redirect occurs then update the leader and retry. | |||
| // If a non-200 status is returned then an error occurred. | |||
| if resp.StatusCode == http.StatusTemporaryRedirect { | |||
| _ = resp.Body.Close() | |||
There was a problem hiding this comment.
Nope. It's a habit I do from using errcheck on other projects. Removed in 00ce4a5.
This commit ensures a commit is written to a quorum before returning from Log.Apply().
| @@ -1024,6 +1030,9 @@ func (l *Log) candidateLoop(closing <-chan struct{}) State { | |||
| elected := make(chan struct{}, 1) | |||
| go l.elect(term, elected, &wg) | |||
|
|
|||
| electionTimer := l.Clock.ElectionTimer() | |||
| defer electionTimer.Stop() | |||
There was a problem hiding this comment.
you're using defer here to stop the timer but not above. This intended?
There was a problem hiding this comment.
The candidate loop doesn't reset the timer so it can just defer when it exits. The follower loop needs to manually close it wherever it exits the function since it can get reset.
|
LGTM, 🚢!!! |
benbjohnson
added a commit
that referenced
this pull request
May 13, 2015
Wait for quorum write before returning from Log.Apply().
|
I'm going to update the changelog for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request ensures a commit is written to a quorum before returning from
Log.Apply(). It also fixes issues with theraft.Clockto ensure that channels are closed when they're not needed and it also fixes someio.Closerobjects that need to be closed.