Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "value" as the field name also in graphite #2545

Merged
merged 1 commit into from
May 13, 2015

Conversation

cannium
Copy link
Contributor

@cannium cannium commented May 12, 2015

#2412 says it's fixed but actually not.

@liyichao
Copy link

Yeah, it's not fixed.

@otoolep
Copy link
Contributor

otoolep commented May 12, 2015

Thanks @cannium -- the tests also need to be updated. Can you do that? If not, I will do so.

@otoolep
Copy link
Contributor

otoolep commented May 12, 2015

Specifically:

--- FAIL: Test_ServerSingleGraphiteIntegration_NoDatabase (3.29s)
    server_integration_test.go:1944: Graphite Connection String: 127.0.0.1:0
    server_integration_test.go:88: Creating cluster of 1 nodes for test graphite integration
    server_integration_test.go:97: Test graphite integration: using tmp directory "/tmp/influxdb-804192646/broker-integration-test" for brokers
    server_integration_test.go:98: Test graphite integration: using tmp directory "/tmp/influxdb-804192646/data-integration-test" for data nodes
    server_integration_test.go:136: http://:37585
    server_integration_test.go:1971: Writing data
    server_integration_test.go:1986: Test "graphite integration" failed, expected: {"results":[{"series":[{"name":"cpu","columns":["time","cpu"],"values":[["2015-05-12T22:38:35Z",23.456]]}]}]}, got: {"results":[{"series":[{"name":"cpu","columns":["time","value"],"values":[["2015-05-12T22:38:35Z",23.456]]}]}]}

and perhaps a couple others.

@cannium cannium force-pushed the use-value-as-field-name branch from d5b956b to 84a713f Compare May 13, 2015 01:32
@cannium
Copy link
Contributor Author

cannium commented May 13, 2015

I fixed the tests, but I seems to hit some other bug. @otoolep Any ideas?

@otoolep
Copy link
Contributor

otoolep commented May 13, 2015

That's a known issue, we're tracking down. #2517

I kicked the build, let's see if it goes green.

@otoolep
Copy link
Contributor

otoolep commented May 13, 2015

@corylanou -- can you also review?

@otoolep
Copy link
Contributor

otoolep commented May 13, 2015

+1 from me, on green build -- thanks @cannium

@corylanou
Copy link
Contributor

Looks good. +1. Thanks!

otoolep added a commit that referenced this pull request May 13, 2015
Use "value" as the field name also in graphite
@otoolep otoolep merged commit 0954828 into influxdata:master May 13, 2015
@toddboom
Copy link
Contributor

@cannium thanks!

@cannium cannium deleted the use-value-as-field-name branch May 13, 2015 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants