-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use "value" as the field name also in graphite #2545
Conversation
Yeah, it's not fixed. |
Thanks @cannium -- the tests also need to be updated. Can you do that? If not, I will do so. |
Specifically:
and perhaps a couple others. |
Also fix tests.
d5b956b
to
84a713f
Compare
I fixed the tests, but I seems to hit some other bug. @otoolep Any ideas? |
That's a known issue, we're tracking down. #2517 I kicked the build, let's see if it goes green. |
@corylanou -- can you also review? |
+1 from me, on green build -- thanks @cannium |
Looks good. +1. Thanks! |
Use "value" as the field name also in graphite
@cannium thanks! |
#2412 says it's fixed but actually not.