Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backup): fix DBRetentionAndShardFromPath parsing error between different OS #25362

Conversation

chengshiwen
Copy link

@chengshiwen chengshiwen commented Sep 18, 2024

Closes #25361

Describe your proposed changes here.

  • I've read the contributing section of the project README.
  • Signed CLA (if not already signed).

Use separatorRegexp = regexp.MustCompile(`[/\\]`) to Split instead of strings.Split(path, string(filepath.Separator))

@davidby-influx @gwossum

@chengshiwen
Copy link
Author

Copy link
Contributor

@davidby-influx davidby-influx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution.

@davidby-influx davidby-influx merged commit 860a74f into influxdata:master-1.x Sep 27, 2024
8 of 9 checks passed
@chengshiwen chengshiwen deleted the fix-backup-between-different-os branch September 29, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants