Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Store.validateArgs wrongfully overwriting start, end unix time (#25146) #25165

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

davidby-influx
Copy link
Contributor

When querying data before 1970-01-01 (UNIX time 0) validateArgs would set start to -in64 max and end to int64 max.

closes #24669

Co-authored-by: Paul Hegenberg paul.hegenberg@gmail.com

closes #25149

…25146)

When querying data before 1970-01-01 (UNIX time 0)
validateArgs would set start to -in64 max and end to int64 max.

closes #24669

Co-authored-by: Paul Hegenberg <paul.hegenberg@gmail.com>

closes #25149
@davidby-influx davidby-influx added kind/bug area/flux Issues related to the Flux query engine team/edge labels Jul 15, 2024
@davidby-influx davidby-influx requested a review from gwossum July 15, 2024 22:14
@davidby-influx davidby-influx self-assigned this Jul 15, 2024
Copy link
Member

@gwossum gwossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Wish the tests were here, but this is simple enough to reason about.

@davidby-influx davidby-influx merged commit c4bfaa8 into master-1.x Jul 16, 2024
9 checks passed
@davidby-influx davidby-influx deleted the DSB_range_valid_master-1.x branch July 16, 2024 15:35
chengshiwen pushed a commit to chengshiwen/influxdb that referenced this pull request Aug 11, 2024
…nfluxdata#25146) (influxdata#25165)

When querying data before 1970-01-01 (UNIX time 0)
validateArgs would set start to -in64 max and end to int64 max.

closes influxdata#24669

Co-authored-by: Paul Hegenberg <paul.hegenberg@gmail.com>

closes influxdata#25149
davidby-influx added a commit that referenced this pull request Aug 12, 2024
…25146) (#25165)

When querying data before 1970-01-01 (UNIX time 0)
validateArgs would set start to -in64 max and end to int64 max.

closes #24669

Co-authored-by: Paul Hegenberg <paul.hegenberg@gmail.com>

closes #25149

(cherry picked from commit c4bfaa8)

closes #25150
davidby-influx added a commit that referenced this pull request Aug 13, 2024
…25146) (#25165) (#25242)

When querying data before 1970-01-01 (UNIX time 0)
validateArgs would set start to -in64 max and end to int64 max.

closes #24669

Co-authored-by: Paul Hegenberg <paul.hegenberg@gmail.com>

closes #25149

(cherry picked from commit c4bfaa8)

closes #25150
chengshiwen pushed a commit to chengshiwen/influxdb that referenced this pull request Aug 27, 2024
…nfluxdata#25146) (influxdata#25165)

When querying data before 1970-01-01 (UNIX time 0)
validateArgs would set start to -in64 max and end to int64 max.

closes influxdata#24669

Co-authored-by: Paul Hegenberg <paul.hegenberg@gmail.com>

closes influxdata#25149
chengshiwen pushed a commit to chengshiwen/influxdb that referenced this pull request Aug 28, 2024
…nfluxdata#25146) (influxdata#25165)

When querying data before 1970-01-01 (UNIX time 0)
validateArgs would set start to -in64 max and end to int64 max.

closes influxdata#24669

Co-authored-by: Paul Hegenberg <paul.hegenberg@gmail.com>

closes influxdata#25149
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/flux Issues related to the Flux query engine kind/bug team/edge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

range() does not filter correctly depending on year [Port to master-1.x]
2 participants