Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure TSMBatchKeyIterator closes all TSMReaders #24957

Merged
merged 3 commits into from
May 6, 2024

Conversation

davidby-influx
Copy link
Contributor

Ensure that compaction does not leave TSMReaders
open when complete, and that KeyIterators are all closed.

@davidby-influx davidby-influx changed the title fix: ensure TSMReaders are closed in compaction fix: ensure all TSMReaders are closed May 3, 2024
@davidby-influx davidby-influx changed the title fix: ensure all TSMReaders are closed fix: ensure TSMBatchKeyIterator closes all TSMReaders May 3, 2024
Copy link
Member

@gwossum gwossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidby-influx davidby-influx marked this pull request as ready for review May 6, 2024 16:34
@davidby-influx davidby-influx merged commit 82cbdb5 into master-1.x May 6, 2024
9 checks passed
@davidby-influx davidby-influx deleted the DSB_ref_unref branch May 6, 2024 16:59
davidby-influx added a commit that referenced this pull request May 6, 2024
…24957)

Do not let errors on closing
a TSMReader prevent other
closes.

(cherry picked from commit 82cbdb5)

closes #24960
davidby-influx added a commit that referenced this pull request May 6, 2024
…24957)

Do not let errors on closing
a TSMReader prevent other
closes.

(cherry picked from commit 82cbdb5)

closes #24961
davidby-influx added a commit that referenced this pull request May 6, 2024
…24957) (#24963)

Do not let errors on closing
a TSMReader prevent other
closes.

(cherry picked from commit 82cbdb5)

closes #24960
davidby-influx added a commit that referenced this pull request May 6, 2024
…24957) (#24964)

Do not let errors on closing
a TSMReader prevent other
closes.

(cherry picked from commit 82cbdb5)

closes #24961
davidby-influx added a commit that referenced this pull request May 6, 2024
…24957) (#24964)

Do not let errors on closing
a TSMReader prevent other
closes.

(cherry picked from commit 82cbdb5)

closes #24961

(cherry picked from commit 0a4d41b)

closes #24962
davidby-influx added a commit that referenced this pull request May 6, 2024
…24957) (#24964) (#24965)

Do not let errors on closing
a TSMReader prevent other
closes.

(cherry picked from commit 82cbdb5)

closes #24961

(cherry picked from commit 0a4d41b)

closes #24962
chengshiwen pushed a commit to chengshiwen/influxdb that referenced this pull request Aug 11, 2024
…nfluxdata#24957)

Do not let errors on closing 
a TSMReader prevent other 
closes.
chengshiwen pushed a commit to chengshiwen/influxdb that referenced this pull request Aug 27, 2024
…nfluxdata#24957)

Do not let errors on closing 
a TSMReader prevent other 
closes.
chengshiwen pushed a commit to chengshiwen/influxdb that referenced this pull request Aug 28, 2024
…nfluxdata#24957)

Do not let errors on closing 
a TSMReader prevent other 
closes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants