-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented Flush() for httpd.responseLogger #2465
Conversation
Link to the mentioned issue: #2466 |
Thanks @Jackkoz -- can you please sign the CLA? |
@otoolep - I've just signed it. |
Thanks @Jackkoz -- I have confirmed that the issue exists, and that this change fixes it. |
We do have a chunked query test here, but it's obviously not checking all behaviour. https://github.com/influxdb/influxdb/blob/master/httpd/handler_test.go#L1658 |
@otoolep I was just looking through tests for that exact thing :-). We should just open an issue to enhance that test to check for this if we want to close this. I agree this is a bug and the fix is correct. +1 |
I am digging into the code now -- what is about the code path the tests take that don't catch this? |
Have you tried checking if the tests turn off logging or use gzipped responses? |
We'll need to look into the testing, but merging this now. |
Implemented Flush() for httpd.responseLogger
This pull request is a solution to issue "Empty respones from server when using chunked responses" that I have reported myself. It is a simple implementation of a missing method in httpd.responseLogger.