Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUnlock server after dropping series #2441

Merged
merged 3 commits into from
Apr 27, 2015
Merged

RUnlock server after dropping series #2441

merged 3 commits into from
Apr 27, 2015

Conversation

otoolep
Copy link
Contributor

@otoolep otoolep commented Apr 27, 2015

This change now unlocks the server after dropping a series via a defer call. There was one place in the code that was not unlocking the server before returning.

@toddboom
Copy link
Contributor

+1 aside from the broken build

otoolep added 3 commits April 27, 2015 14:19
This change means that lock control can use the defer call, which means
there is no chance the RLock will be left locked at function exit
Previously this code was more complex as it managed locks manually,
since the RLock must be released to allow the "drop series" broadcast
message go through.
@otoolep otoolep force-pushed the add_missing_unlock branch from eb7602b to 2634853 Compare April 27, 2015 21:22
toddboom added a commit that referenced this pull request Apr 27, 2015
RUnlock server after dropping series
@toddboom toddboom merged commit 07774b2 into master Apr 27, 2015
@toddboom toddboom deleted the add_missing_unlock branch May 4, 2015 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants