fix: do not escape CSV output #24311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CSV output is incorrectly escaped. Add a boolean flag to tag output functions to prevent this. closes #24309
btasker
approved these changes
Jun 29, 2023
|
@btasker - Thanks, will create plutonium issues for master and 1.11 branches to
|
gwossum
approved these changes
Jun 29, 2023
There was a problem hiding this comment.
This is a definite improvement and addresses the original issue. One thing to note is that if a tag can contain a comma, double quote, or CR/LF then that field will require quoting. I'm not sure if it's even possible to get tags with those characters in it. I don't think we should attempt to address CSV quoting until we actually find an issue.
davidby-influx
added a commit
that referenced
this pull request
Jun 29, 2023
davidby-influx
added a commit
that referenced
this pull request
Jun 29, 2023
chengshiwen
pushed a commit
to chengshiwen/influxdb
that referenced
this pull request
Aug 26, 2024
CSV output is incorrectly escaped. Add a boolean flag to tag output functions to prevent this. closes influxdata#24309
chengshiwen
pushed a commit
to chengshiwen/influxdb
that referenced
this pull request
Aug 27, 2024
CSV output is incorrectly escaped. Add a boolean flag to tag output functions to prevent this. closes influxdata#24309
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSV output is incorrectly escaped.
Add a boolean flag to tag output
functions to prevent this.
closes #24309