Always append shard path in diags #2431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otoolep
force-pushed
the
diags_path_issues
branch
from
b4ac4aa to
b0beda8
Compare
This was referenced Apr 25, 2015
|
Before this change the column |
|
@otoolep PR is clean and better. 👍 . I didn't want to change too much as I still don't know how internals work. |
|
+1 |
This code is clearer -- simply append an empty path if the shard is not local. Fixes issue #2430
otoolep
force-pushed
the
diags_path_issues
branch
from
b0beda8 to
257aa4d
Compare
otoolep
added a commit
that referenced
this pull request
Apr 26, 2015
Always append shard path in diags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is clearer -- simply append an empty path if the shard is not
local.
Fixes issue #2430