Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add the ability to log queries killed by query-timeout (1.11 backport) #24048

Merged
merged 1 commit into from
Jan 20, 2023
Merged

feat: add the ability to log queries killed by query-timeout (1.11 backport) #24048

merged 1 commit into from
Jan 20, 2023

Conversation

jeffreyssmith2nd
Copy link
Contributor

@jeffreyssmith2nd jeffreyssmith2nd commented Jan 18, 2023 •
edited
Loading

Required checklist

  • Sample config files updated (both /etc folder and NewDemoConfig methods) (influxdb and plutonium)

Note for reviewers:

Check the semantic commit type:

  • Feat: a feature with user-visible changes
  • Fix: a bug fix that we might tell a user “upgrade to get this fix for your issue”
  • Chore: version bumps, internal doc (e.g. README) changes, code comment updates, code formatting fixes… must not be user facing (except dependency version changes)
  • Build: build script changes, CI config changes, build tool updates
  • Refactor: non-user-visible refactoring
  • Check the PR title: we should be able to put this as a one-liner in the release notes

@jeffreyssmith2nd
feat: add the ability to log queries killed by query-timeout (#23978)
def3658 
* feat: add the ability to log queries killed by `query-timeout`

* chore: update example config

* chore: improve logging details
@jeffreyssmith2nd jeffreyssmith2nd marked this pull request as ready for review January 19, 2023 14:14
@gwossum
Copy link
Member

gwossum commented Jan 19, 2023

@jeffreyssmith2nd Is there a docs PR for the new config option?

@jeffreyssmith2nd
Copy link
Contributor Author

@gwossum There is now! influxdata/docs-v2#4705

gwossum
gwossum approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@gwossum gwossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeffreyssmith2nd jeffreyssmith2nd mentioned this pull request Jan 20, 2023
Closed
2 tasks
@jeffreyssmith2nd jeffreyssmith2nd merged commit d228760 into 1.11 Jan 20, 2023
@jeffreyssmith2nd jeffreyssmith2nd deleted the smith/backport-query-logging branch January 20, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwossum gwossum gwossum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffreyssmith2nd @gwossum