Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mean and percentile function fixes #2404

Merged
merged 5 commits into from
Apr 23, 2015
Merged

Mean and percentile function fixes #2404

merged 5 commits into from
Apr 23, 2015

Conversation

jwilder
Copy link
Contributor

@jwilder jwilder commented Apr 23, 2015

This PR fixes #2374 which had two panics related to percentiles. It also fixes a JSON marshaling exception when NaN is returned from a mean function.

jwilder added a commit that referenced this pull request Apr 23, 2015
jwilder added 5 commits April 23, 2015 11:18
…orted value: NaN

If the MapMean did not have any values in the iterator, it would return
and empty meanMapOutput().  ReduceMean would in turn divider the results
by an unitialized float64 producing a NaN.  NaN is not serializable to JSON
by default.
@toddboom
Copy link
Contributor

👍

jwilder added a commit that referenced this pull request Apr 23, 2015
Mean and percentile function fixes
@jwilder jwilder merged commit f3ece1a into master Apr 23, 2015
@jwilder jwilder deleted the jw-int-tests branch April 23, 2015 17:25
@@ -1456,9 +1456,7 @@ func TestSingleServerDiags(t *testing.T) {
t.Skip(fmt.Sprintf("skipping '%s'", testName))
}
dir := tempfile()
defer func() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think go lint will complain about these changes. Not sure, but I think so. We don't run lint right now, so perhaps it doesn't matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two different panics during SELECT percentile
4 participants