fix: series file index compaction #23916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Series file indices monotonically grew even when series were deleted. Partially closes influxdata/EAR#3643
davidby-influx
force-pushed
the
DSB_series_compress
branch
from
76bb9ba to
34ec21c
Compare
gwossum
reviewed
Jun 1, 2023
Comment on lines
+587
to
+589
| seriesCount := seriesN | ||
| for { | ||
| seriesN = seriesCount |
There was a problem hiding this comment.
I'm a little confused by what's going on here. Part of this may be due to changing the value of the input parameter seriesN. This changes the meaning of seriesN in the function call vs the function body. Copying to a different variable before using might help. A comment explaining what seriesN and seriesCount represent as the function runs would also help.
There was a problem hiding this comment.
That helps. Weird whitespace, but not going to worry about that.
davidby-influx
added a commit
that referenced
this pull request
Jun 1, 2023
Series file indices monotonically grew even when series were deleted. Also stop ignoring error in series index recovery Partially closes influxdata/EAR#3643 (cherry picked from commit 53856cd)
davidby-influx
added a commit
that referenced
this pull request
Jun 1, 2023
Series file indices monotonically grew even when series were deleted. Also stop ignoring error in series index recovery Partially closes influxdata/EAR#3643 (cherry picked from commit 53856cd)
chengshiwen
pushed a commit
to chengshiwen/influxdb
that referenced
this pull request
Aug 11, 2024
Series file indices monotonically grew even when series were deleted. Also stop ignoring error in series index recovery Partially closes https://github.com/influxdata/EAR/issues/3643
chengshiwen
pushed a commit
to chengshiwen/influxdb
that referenced
this pull request
Aug 27, 2024
Series file indices monotonically grew even when series were deleted. Also stop ignoring error in series index recovery Partially closes https://github.com/influxdata/EAR/issues/3643
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Series file indices monotonically grew even
when series were deleted.
Partially
closes https://github.com/influxdata/EAR/issues/3643