fix: add tests for file rename across volumes #23787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffreyssmith2nd
approved these changes
Oct 13, 2022
|
|
||
| // CreateTempFileOrFail creates a temporary file returning the path to the file. | ||
| func MustCreateTempFile(t testing.TB, data string) string { | ||
| t.Helper() |
There was a problem hiding this comment.
What does this function call do here?
There was a problem hiding this comment.
// Helper marks the calling function as a test helper function.
// When printing file and line information, that function will be skipped.
// Helper may be called simultaneously from multiple goroutines.
davidby-influx
added a commit
that referenced
this pull request
Oct 13, 2022
Also move shared code from file_unix.go (cherry picked from commit bc8d9ea)
davidby-influx
added a commit
that referenced
this pull request
Oct 13, 2022
When a file rename fails with EXDEV (cross device or volume error), copy the file and delete the original instead Differs from master branch by overwriting existing files instead of erring. closes #22997 (cherry picked from commit 0913276) * fix: add tests for file rename across volumes (#23787) Also move shared code from file_unix.go (cherry picked from commit bc8d9ea) closes #23791
chengshiwen
pushed a commit
to chengshiwen/influxdb
that referenced
this pull request
Aug 11, 2024
Also move shared code from file_unix.go
chengshiwen
pushed a commit
to chengshiwen/influxdb
that referenced
this pull request
Aug 27, 2024
Also move shared code from file_unix.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for #22997