Actually allow HTTP logging to be enabled #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otoolep
force-pushed
the
control_http_loggign
branch
2 times, most recently
from
ec7210a to
4914bde
Compare
|
HTTP access logging must be controlled at handler-construction time, since construction is when routing, and logging, are actually set. |
|
Currently failing on Circle, investigating. |
otoolep
force-pushed
the
control_http_loggign
branch
from
418514e to
5ff1bd1
Compare
|
Confirmed HTTP logging visible again. 👍 |
|
Thanks @mark-rushakoff |
otoolep
added a commit
that referenced
this pull request
Apr 21, 2015
Actually allow HTTP logging to be enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.