Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fully clean up partially opened TSI (#23430) #23454

Merged
merged 2 commits into from
Jun 14, 2022

Conversation

davidby-influx
Copy link
Contributor

When one partition in a TSI fails to open, all previously opened
partitions should be cleaned up, and remaining partitions
should not be opened

closes #23427

(cherry picked from commit d3db48e)

closes #23432

When one partition in a TSI fails to open, all previously opened
partitions should be cleaned up, and remaining partitions
should not be opened

closes #23427

(cherry picked from commit d3db48e)

closes #23432
Copy link
Contributor

@serenibyss serenibyss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from the issue in go.mod

go.mod Outdated
@@ -32,6 +32,7 @@ require (
github.com/influxdata/flux v0.169.0
github.com/influxdata/httprouter v1.3.1-0.20191122104820-ee83e2772f69
github.com/influxdata/influx-cli/v2 v2.2.1-0.20220318222112-88ba3464cd07
github.com/influxdata/influxdb v1.9.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think one of your import paths might have changed and caused this to get added to go.mod

@davidby-influx davidby-influx merged commit a9df3f8 into master Jun 14, 2022
@davidby-influx davidby-influx deleted the DSB_cleanup_open_master branch June 14, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fully clean up partially opened TSI [port to 2.X] Fully clean up partially opened TSI.
2 participants