fix: replace unprintable and invalid characters in errors (#23387) #23395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidby-influx
added
kind/bug
area/2.x
gwossum
reviewed
Jun 1, 2022
Comment on lines
+33
to
+51
| for i := range tests { | ||
| f := makePrintable(tests[i].raw) | ||
| require.True(t, models.ValidToken([]byte(f))) | ||
| c := 0 | ||
| nSeq := 0 | ||
| for _, r := range f { | ||
| if r == unPrintReplRune { | ||
| c++ | ||
| if c == 1 { | ||
| nSeq++ | ||
| } | ||
| require.LessOrEqual(t, c, unPrintMaxReplRune, "too many repeated %c", unPrintReplRune) | ||
| } else { | ||
| c = 0 | ||
| } | ||
| } | ||
| require.Equalf(t, tests[i].nSeq, nSeq, "wrong number of elided sequences of replacement characters") | ||
| } | ||
| } |
There was a problem hiding this comment.
I'd prefer a simpler and more robust test against an expected literal, but I won't hold it against a cherry pick
There was a problem hiding this comment.
You and @lesam both want literal comparisons, so I am now on that train for the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace unprintable and invalid characters with '?'
in logged errors. Truncate consecutive runs of them to
only 3 repeats of '?'
closes #23386
(cherry picked from commit 0ae0bd6)
closes #23389