Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove data directory appending for influx_inspect verify #23336

Merged
merged 1 commit into from
May 14, 2022
Merged

fix: remove data directory appending for influx_inspect verify #23336

merged 1 commit into from
May 14, 2022

Conversation

candrewlee14
Copy link
Contributor

This removes the line that appends "/data" to the given -dir path for influx_inspect verify.
Since the loadFiles method uses filepath.Walk, TSM files in a /data directory will still be checked, as well as other any other TSM files in the root directory or its subdirectories.

Closes #22572

@candrewlee14 candrewlee14 linked an issue May 11, 2022 that may be closed by this pull request
influx_inspect verify always append /data folder #22572
Closed
serenibyss
serenibyss approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@serenibyss serenibyss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@candrewlee14 candrewlee14 merged commit 7c31f92 into master-1.x May 14, 2022
@candrewlee14 candrewlee14 deleted the fix-inspect-verify-datapath branch May 14, 2022 00:58
@serenibyss serenibyss mentioned this pull request May 16, 2022
Closed
bnpfeife pushed a commit that referenced this pull request May 17, 2022
@candrewlee14 @bnpfeife
fix: remove data directory appending for influx_inspect verify (#23336)
674886e 
influx_inspect verify -dir will no longer append the "/data" path to the dir.  Files are checked recursively, so this will still include files in the "/data" path as well as other subdirectories.
 
closes #22572
@serenibyss serenibyss mentioned this pull request May 17, 2022
Merged
3 tasks
@jeffreyssmith2nd jeffreyssmith2nd mentioned this pull request Jul 13, 2022
Closed
@davidby-influx davidby-influx mentioned this pull request Nov 10, 2022
Closed
chengshiwen pushed a commit to chengshiwen/influxdb that referenced this pull request Aug 27, 2024
@candrewlee14 @chengshiwen
fix: remove data directory appending for influx_inspect verify (influ…
ef3059d 
…xdata#23336)

influx_inspect verify -dir will no longer append the "/data" path to the dir.  Files are checked recursively, so this will still include files in the "/data" path as well as other subdirectories.
 
closes influxdata#22572
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serenibyss serenibyss serenibyss approved these changes

Assignees
No one assigned
Labels
1.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

influx_inspect verify always append /data folder
2 participants
@candrewlee14 @serenibyss