Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MeasurementsCardinality should not be less than 0 #23286

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

gwossum
Copy link
Member

@gwossum gwossum commented Apr 20, 2022

Clamp the value of Store.MeasurementsCardinality so that it can not be less
than 0. This primarily shows up as a negative numMeasurements value in
/debug/vars under some circumstances.

Closes #23285

Clamp the value of Store.MeasurementsCardinality so that it can not be less
than 0. This primarily shows up as a negative `numMeasurements` value in
/debug/vars under some circumstances.

refs #23285
@gwossum gwossum marked this pull request as ready for review April 20, 2022 22:27
Copy link
Contributor

@davidby-influx davidby-influx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gwossum gwossum merged commit 160cf67 into master-1.x Apr 21, 2022
@gwossum gwossum deleted the gw-fix-23285 branch April 21, 2022 18:32
gwossum added a commit that referenced this pull request Apr 21, 2022
Clamp the value of Store.MeasurementsCardinality so that it can not be less
than 0. This primarily shows up as a negative `numMeasurements` value in
/debug/vars under some circumstances.

refs #23285

(cherry picked from commit 160cf67)
gwossum added a commit that referenced this pull request May 18, 2022
* fix: MeasurementsCardinality should not be less than 0 (#23286)

Clamp the value of Store.MeasurementsCardinality so that it can not be less
than 0. This primarily shows up as a negative `numMeasurements` value in
/debug/vars under some circumstances.

refs #23285

(cherry picked from commit 160cf67)
chengshiwen pushed a commit to chengshiwen/influxdb that referenced this pull request Aug 11, 2024
)

Clamp the value of Store.MeasurementsCardinality so that it can not be less
than 0. This primarily shows up as a negative `numMeasurements` value in
/debug/vars under some circumstances.

refs influxdata#23285
chengshiwen pushed a commit to chengshiwen/influxdb that referenced this pull request Aug 27, 2024
)

Clamp the value of Store.MeasurementsCardinality so that it can not be less
than 0. This primarily shows up as a negative `numMeasurements` value in
/debug/vars under some circumstances.

refs influxdata#23285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants