Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2286: parse error on CREATE CONTINUOUS QUERY #2326

Merged
merged 1 commit into from
Apr 17, 2015
Merged

Conversation

dgnorton
Copy link
Contributor

This turned out to be an issue in the AST code instead of the parser. server.go calls the String() method on the CQ so it can be sent to applyCreateContinuousQuery, which then re-parses the query. The String() method on type CreateContinuousQueryStatement was not quoting identifiers causing the parse in applyCreateContinuousQuery to fail.

Also fixed a bug in the parser_test.go. It wasn't checking the results of parsing CQs.

@otoolep
Copy link
Contributor

otoolep commented Apr 17, 2015

What is the issue?

@dgnorton
Copy link
Contributor Author

#2286

@otoolep
Copy link
Contributor

otoolep commented Apr 17, 2015

+1

dgnorton added a commit that referenced this pull request Apr 17, 2015
fix #2286: parse error on CREATE CONTINUOUS QUERY
@dgnorton dgnorton merged commit e890468 into master Apr 17, 2015
@dgnorton dgnorton deleted the fix-2286 branch April 17, 2015 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants