Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use nil as default return value for MapCount #2291

Closed
wants to merge 2 commits into from

Conversation

neonstalwart
Copy link
Contributor

this fixes #2271 and includes #2290

if someone could direct me where to put a test i'd be glad to try to add one

@otoolep
Copy link
Contributor

otoolep commented Apr 15, 2015

@neonstalwart -- thanks. You should add a unit test to here:

https://github.com/influxdb/influxdb/blob/master/cmd/influxd/server_integration_test.go#L888

feel free to reset the database and write a little bit of data, then query it. Let me know if you have any questions.

@otoolep
Copy link
Contributor

otoolep commented Apr 15, 2015

Once a unit test is added (I can add it if necessary), I test it by hand too, then we can merge this.

@neonstalwart
Copy link
Contributor Author

ok, i'll take a shot at adding the unit test - i think it looks like something i can manage. if you get impatient, go ahead with it yourself - it won't hurt my feelings

@otoolep
Copy link
Contributor

otoolep commented Apr 15, 2015

Re-opened at the PR below, so I can debug the test failure.

#2295

@otoolep otoolep closed this Apr 15, 2015
@neonstalwart neonstalwart deleted the fix/2271 branch April 27, 2015 19:09
mark-rushakoff pushed a commit that referenced this pull request Jan 8, 2019
feat(ui/onboarding): Allow filtering of plugin bundles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inconsistent results for aggregate queries
2 participants