fix #2268: fix expression parsing bug #2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you explain the |
|
@benbjohnson sometimes it needs to replace the entire expression tree and other times in descents into the tree and modifies a sub node. I hate this change...I'm sure there's a cleaner way that I'm just not seeing. This was what I wanted to pair on yesterday. I have an idea that'll I'll try. If that doesn't clean it up then maybe we can pair for 15 - 20 min later today. |
Parsing: WHERE time > now() - 2d AND time < now() + 10d generated an expression tree that evaluated as: ... AND (time < now()) + 10d instead of: ... AND time < (now() + 10d)
|
@dgnorton sure, sounds good. |
|
👍 if you can make ben happy. 💃 |
|
works for me |
| } | ||
| } else { | ||
| expr = &BinaryExpr{LHS: expr, RHS: rhs, Op: op} | ||
|
|
There was a problem hiding this comment.
Nit: looks like a superfluous blank line here.
|
Some super-picky nits, test case looks good. +1 on green build. |
dgnorton
added a commit
that referenced
this pull request
Apr 15, 2015
fix #2268: fix expression parsing bug
This was referenced Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@benbjohnson
Before the fix...
After the fix...