fix: extend snapshot copy to filesystems that cannot link #22703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If os.Link fails with syscall.ENOTSUP, then the file system does not support links, and we must make copies to snapshot files for backup. We also automatically make copies instead of link on Windows, because although it makes links, their semantics are different from Linux. closes #16739
davidby-influx
force-pushed
the
DSB_copy_link
branch
from
35f68f0 to
90958dc
Compare
lesam
reviewed
Oct 21, 2021
| // Windows does not permit deleting a file with open file handles | ||
| // Azure does not support hard links in its default file system | ||
|
|
||
| func (f *FileStore) copyNotLink(oldPath, newPath string) (returnErr error) { |
There was a problem hiding this comment.
function comment should follow godoc format (I don't think the extra whitespace line is correct?)
There was a problem hiding this comment.
That's the sort of thing I expect go fmt to catch, but clearly not the case....
lesam
reviewed
Oct 21, 2021
| } else { | ||
| return fmt.Errorf("error creating hard link for backup from %s to %s: %w", oldPath, newPath, err) | ||
| } | ||
| } else { |
There was a problem hiding this comment.
Why the else? Just return nil at the end of the function would be clearer I think.
There was a problem hiding this comment.
Because I am an old C coder with damaged neurons.
lesam
reviewed
Oct 21, 2021
lesam
approved these changes
Oct 21, 2021
davidby-influx
added a commit
that referenced
this pull request
Oct 21, 2021
If os.Link fails with syscall.ENOTSUP, then the file system does not support links, and we must make copies to snapshot files for backup. We also automatically make copies instead of link on Windows, because although it makes links, their semantics are different from Linux. closes #16739 (cherry picked from commit d9b9e86) closes #22700
davidby-influx
added a commit
that referenced
this pull request
Oct 21, 2021
…22730) If os.Link fails with syscall.ENOTSUP, then the file system does not support links, and we must make copies to snapshot files for backup. We also automatically make copies instead of link on Windows, because although it makes links, their semantics are different from Linux. closes #16739 (cherry picked from commit d9b9e86) closes #22700
davidby-influx
added a commit
that referenced
this pull request
Oct 21, 2021
If os.Link fails with syscall.ENOTSUP, then the file system does not support links, and we must make copies to snapshot files for backup. We also automatically make copies instead of link on Windows, because although it makes links, their semantics are different from Linux. closes #16739 (cherry picked from commit d9b9e86) closes #22701
davidby-influx
added a commit
that referenced
this pull request
Oct 22, 2021
…22732) If os.Link fails with syscall.ENOTSUP, then the file system does not support links, and we must make copies to snapshot files for backup. We also automatically make copies instead of link on Windows, because although it makes links, their semantics are different from Linux. closes #16739 (cherry picked from commit d9b9e86) closes #22701
chengshiwen
pushed a commit
to chengshiwen/influxdb
that referenced
this pull request
Aug 27, 2024
…#22703) If os.Link fails with syscall.ENOTSUP, then the file system does not support links, and we must make copies to snapshot files for backup. We also automatically make copies instead of link on Windows, because although it makes links, their semantics are different from Linux. closes influxdata#16739
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
os.Linkfails withsyscall.ENOTSUP, then the filesystem does not support links, and we must make copies
of snapshot files for backup. We also automatically make
copies instead of link on Windows, because although it
makes links, their semantics are different from Linux.
closes #16739