feat: list-bucket API supports pagination when filtering by org #22674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21392
There was already some low-level logic in place to handle bucket pagination, but it was bypassed any time an
OrgIDfilter was specified (because filtering by org ID uses a special secondary index). This PR adds the missing support forafteranddescendingto the filter-by-org-ID branch of logic.Without introducing a new index (or two), I had to resort to scanning the org-focused index to implement support for these two parameters. We can revisit if this turns out to be a perf problem.