fix(upgrade): don't drop shard-group durations when upgrading DBs #22650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxmoran
commented
Oct 11, 2021
| // This is expected to be 0 for all buckets created before | ||
| // we began tracking it in metadata. | ||
| ShardGroupDuration time.Duration `json:"shardGroupDuration"` | ||
| func repairMissingShardGroupDurations(ctx context.Context, store kv.SchemaStore) error { |
There was a problem hiding this comment.
The repair logic in the new migration is identical to the logic in the migration I added to initialize shard-group duration values in v2.0.5. I extracted the logic into a function so it could be reused.
davidby-influx
approved these changes
Oct 11, 2021
| return err | ||
| if b.ShardGroupDuration == 0 { | ||
| // Backfill the duration using the same method used | ||
| // to dervie the value within the storage engine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22649
influxd upgradehas been dropping shard-group duration values. Users who upgraded prior to v2.0.5 weren't affected because (as part of enabling updates to shard-group-durations in that version) a KV migration was added to fill in default duration values in the boltDB. Users who upgraded on-or-after v2.0.5 will have been affected, which is likely contributing to the recent reports we've gotten about decreased ingest performance in 2.0.x.