-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new recovery subcommand allows creating recovery user/token #22590
Conversation
b5b6e5b
to
8ae3f28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't review fully yet since my question about command names could cause refactoring.
Another thought I had: I've previously wished for an influxd setup
command that would do the same thing as influx setup
/influxd upgrade
. If that command supported something like a --force
or --ignore-existing
flag, would implementing that be another way to achieve this functionality? Having it could help us simplify a piece of our DockerHub build's entrypoint script.
I thought about just calling the same code we use for setup, but that seemed more complicated for users since then they need to know whether they want to recreate buckets and orgs, or just re-add an operator token to an existing user. I feel like 'add/list user' and 'add operator token' being separate would be a great idea though - then if the user remembers their username they can just add a new token and they're up and running (they can use the new operator token to reset their password). If they're really sunk they can list users or even add a new one. Maybe @russorat should comment? |
ee62a8e
to
6e6d565
Compare
Changed to have a Because there are so many of these, I decided to add a new top-level |
New command help:
|
600c662
to
c825e62
Compare
Co-authored-by: Daniel Moran <danxmoran@gmail.com>
@@ -2,6 +2,104 @@ module github.com/influxdata/influxdb/v2 | |||
|
|||
go 1.17 | |||
|
|||
require ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why go mod tidy
decided to re-arrange things like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure either, but I've seen it before since the 1.17 upgrade. I've been merging them back together and then go mod tidy
-ing to re-sort, not sure if it's worth continuing to fight it
@@ -430,8 +430,8 @@ github.com/influxdata/flux v0.133.0 h1:U1zYP5qXjh6esGOMc4d8efkTgqNORDc9KRWc6NIZs | |||
github.com/influxdata/flux v0.133.0/go.mod h1:RzogdNsdZoyDAw53BwLrhqyrVI7eT0IKEWW2UjAvTiw= | |||
github.com/influxdata/httprouter v1.3.1-0.20191122104820-ee83e2772f69 h1:WQsmW0fXO4ZE/lFGIE84G6rIV5SJN3P3sjIXAP1a8eU= | |||
github.com/influxdata/httprouter v1.3.1-0.20191122104820-ee83e2772f69/go.mod h1:pwymjR6SrP3gD3pRj9RJwdl1j5s3doEEV8gS4X9qSzA= | |||
github.com/influxdata/influx-cli/v2 v2.1.1-0.20210924182719-d0640ad6c4d4 h1:brA9egXkPF/ZGKbPu2Vt7GXJ4cv5Oo6eSff4ykhnwTE= | |||
github.com/influxdata/influx-cli/v2 v2.1.1-0.20210924182719-d0640ad6c4d4/go.mod h1:piIN/dAOSRqdZZc2sHO7CORuWUQ0UXdNrjugF3cEr8k= | |||
github.com/influxdata/influx-cli/v2 v2.1.1-0.20211006152725-857e2b356cc0 h1:2tFXbj1A3pRpuccDUEro4ZZYVAmAJgFha60Oz4+kSCE= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the expected change in go.sum though.
Closes #12051