fix(tsdb): sync series segment to disk after writing #22545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am running some performance benchmarking on this PR, I will drop that commit once the CI pipeline finishes |
|
We should probably backport this to 1.9 and master-1.x branches. |
serenibyss
force-pushed
the
sync-series-segment
branch
from
ac32cdd to
0905c0c
Compare
serenibyss
approved these changes
Sep 23, 2021
serenibyss
pushed a commit
that referenced
this pull request
Sep 23, 2021
Co-authored-by: Tristan Su <suqing.sq@alibaba-inc.com>
serenibyss
pushed a commit
that referenced
this pull request
Sep 23, 2021
Co-authored-by: Tristan Su <suqing.sq@alibaba-inc.com>
This was referenced Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22544, #20245