Allow HTTP logging to be controlled #2246
Conversation
otoolep
force-pushed
the
increase_test_timeout
branch
from
3e684d3 to
1f21773
Compare
otoolep
changed the title
| Logger *log.Logger | ||
| WriteTrace bool // Detailed logging of write path | ||
| Logger *log.Logger | ||
| HTTPAccessLogging bool // Log every HTTP access. |
There was a problem hiding this comment.
Can we just make this something like EnableLogging or LoggingEnabled? This name is confusing when I don't see it in context.
|
I also increased the interval between querying the server during testing to 100ms. I originally suggested 10ms, may mean less strain on the Circle container, and it should not actually make a difference to how long tests take to run. |
| @@ -239,6 +240,10 @@ func NewConfig() *Config { | |||
| c.Snapshot.BindAddress = DefaultSnapshotBindAddress | |||
| c.Snapshot.Port = DefaultSnapshotPort | |||
|
|
|||
| c.Logging.HTTPAccess = true | |||
There was a problem hiding this comment.
There is an HTTPAPI section. Should we put logging under that? This logging section is starting to feel out of place. Each are could have it's own logging flag now if we wanted.
There was a problem hiding this comment.
Possibly. I could go either way. Would you agree to punting on that?
There was a problem hiding this comment.
Distinct PR, perhaps?
|
Integration test output is so much easier to work with now, I do think we should merge this (or something close to it). |
otoolep
force-pushed
the
increase_test_timeout
branch
from
efbd6e2 to
3db052a
Compare
|
Updated with change to HTTP logging flag. |
|
@otoolep I'm fine with it in current state. Our config might need some re-org at some point in the future anyway. I do agree this was very much needed. It was getting impossible to look through the failed CI output. Thanks! |
|
Also fixes issue #2245. |
|
Thanks @corylanou -- CircleCI runs already looking more stable on this branch. |
otoolep
force-pushed
the
increase_test_timeout
branch
7 times, most recently
from
39fd77e to
b02ca81
Compare
It would appear this should not have been committed.
Each of these tests relies on a write of only a few points. It simply should not take 60 seconds.
otoolep
force-pushed
the
increase_test_timeout
branch
from
b02ca81 to
bb78898
Compare
otoolep
force-pushed
the
increase_test_timeout
branch
from
ef413bd to
50c1fa3
Compare
|
Fixes issue #2302 |
otoolep
force-pushed
the
increase_test_timeout
branch
2 times, most recently
from
abbf99b to
ef413bd
Compare
|
Closed in favour of #2320 |
This change also re-enables DQ testing, as well as remove a bogus
warnstatement.