fix: ensure files are closed before they are deleted or moved in deletetsm
#22458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxmoran
commented
Sep 13, 2021
|
|
||
| // Replace original file with new file. | ||
| if err := os.Rename(outputPath, path); err != nil { | ||
| if err := file.RenameFile(outputPath, path); err != nil { |
There was a problem hiding this comment.
Existing helper to first delete path if it's there, then move outputPath -> path
serenibyss
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows is apparently really strict about enforcing that there are no open handles to a file when you try to move or delete it; if there's a dangling reference, you get a permissions error. It also prevents a move that overwrites an existing file; you have to delete the file at the destination first, then move.