fix: better error for no data from snapshots #22452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesam
commented
Sep 13, 2021
| return fmt.Errorf("copy backup to file: err=%v, n=%d", err, n) | ||
| } | ||
| if n == 0 { | ||
| // Unfortunately there is no out-of-band channel to actually return errors from the snapshot service, just |
There was a problem hiding this comment.
In 2.x and 1.x Enterprise this API has a much improved wire format and will properly transmit errors. Not worth fixing in 1.x OSS, but we can at least point at the server side logs which will have the real error.
lesam
added a commit
to lesam/influxdb
that referenced
this pull request
Oct 4, 2021
Closes: influxdata#22450 (cherry picked from commit 84b785b)
lesam
added a commit
that referenced
this pull request
Oct 4, 2021
lesam
added a commit
to lesam/influxdb
that referenced
this pull request
Oct 13, 2021
Closes: influxdata#16739 (cherry picked from commit 84b785b)
lesam
added a commit
that referenced
this pull request
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #16739