Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: detect noninteractive prompt when displaying warning in buildtsi #22442

Merged
merged 1 commit into from
Sep 13, 2021
Merged

fix: detect noninteractive prompt when displaying warning in buildtsi #22442

merged 1 commit into from
Sep 13, 2021

Conversation

danxmoran
Copy link
Contributor

The most immediate benefit of this is that it allows the buildtsi unit tests to pass when running tests as a root user, which is what happens when we use our cross-builder image in 2.x CI.

@danxmoran danxmoran requested a review from mcfarlm3 September 13, 2021 13:40
mcfarlm3
mcfarlm3 approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@mcfarlm3 mcfarlm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense to me and seems pretty straightforward.

@danxmoran danxmoran merged commit f36960d into master Sep 13, 2021
@danxmoran danxmoran deleted the dm-buildtsi-noninteractive branch September 13, 2021 15:27
@williamhbaker williamhbaker mentioned this pull request Oct 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcfarlm3 mcfarlm3 mcfarlm3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danxmoran @mcfarlm3