Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add additional log to flux e2e tests #22366

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

williamhbaker
Copy link
Contributor

Closes #22365

This adds some additional logging output in the event of a failed flux e2e test. If a test fails, a query will be run to get all the data from the bucket, and log it in a format looking like this:

            end_to_end_test.go:256: all data in TestFluxEndToEnd/planner/window_eval:
            end_to_end_test.go:244: ,result,table,_start,_stop,_time,_value,_field,_measurement,host
            end_to_end_test.go:244: ,_result,0,1970-01-01T00:00:00Z,2021-09-01T19:56:15.694996Z,2018-05-22T19:53:26Z,1.83,load1,system,host.local
            end_to_end_test.go:244: ,_result,0,1970-01-01T00:00:00Z,2021-09-01T19:56:15.694996Z,2018-05-22T19:53:36Z,1.72,load1,system,host.local
            end_to_end_test.go:244: ,_result,0,1970-01-01T00:00:00Z,2021-09-01T19:56:15.694996Z,2018-05-22T19:53:37Z,1.77,load1,system,host.local
            end_to_end_test.go:244: ,_result,0,1970-01-01T00:00:00Z,2021-09-01T19:56:15.694996Z,2018-05-22T19:53:56Z,1.63,load1,system,host.local
            end_to_end_test.go:244: ,_result,0,1970-01-01T00:00:00Z,2021-09-01T19:56:15.694996Z,2018-05-22T19:54:06Z,1.91,load1,system,host.local
            end_to_end_test.go:244: ,_result,0,1970-01-01T00:00:00Z,2021-09-01T19:56:15.694996Z,2018-05-22T19:54:16Z,1.84,load1,system,host.local
            end_to_end_test.go:244: ,_result,1,1970-01-01T00:00:00Z,2021-09-01T19:56:15.694996Z,2018-05-22T19:53:26Z,1.98,load3,system,host.local
            end_to_end_test.go:244: ,_result,1,1970-01-01T00:00:00Z,2021-09-01T19:56:15.694996Z,2018-05-22T19:53:36Z,1.97,load3,system,host.local
            end_to_end_test.go:244: ,_result,1,1970-01-01T00:00:00Z,2021-09-01T19:56:15.694996Z,2018-05-22T19:53:46Z,1.97,load3,system,host.local

This will help troubleshoot cases where the returned data is not as expected from the actual test case.

@williamhbaker williamhbaker marked this pull request as ready for review September 1, 2021 20:33
Copy link
Contributor

@davidby-influx davidby-influx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add additional logging for failed flux e2e tests
2 participants