Term signal #2236
Merged
Term signal #2236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| return | ||
| } | ||
|
|
There was a problem hiding this comment.
You can now pull pprof profiles if you run:
$ go tool pprof http://localhost:8086/debug/pprof/profileMore info on the net/http/pprof page. Make sure you change their :6060 ports to :8086 though.
benbjohnson
force-pushed
the
term-signal
branch
from
3d9899b to
6a40442
Compare
| select { | ||
| case l.terms <- struct{}{}: | ||
| default: | ||
| } | ||
| } |
There was a problem hiding this comment.
Term updates immediately but signals asynchronously.
This commit changes raft so that term changes are made immediately and term change signals are made afterward. Previously, election timeouts were invalidated by incoming term changes which caused an election loop. Stale term was also fixed and http/pprof was added too.
benbjohnson
force-pushed
the
term-signal
branch
from
6a40442 to
eaf4bfc
Compare
|
+1 |
mark-rushakoff
pushed a commit
that referenced
this pull request
Jan 11, 2019
fix(bolt): fix auth status update error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request changes raft so that term changes are made immediately and term change signals are made afterward. Previously, election timeouts were invalidated by incoming term changes which caused an election loop.
Stale term was also fixed and http/pprof was added too.