fix: flux error properly read by cloud #22348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before this change:
After this change:
|
lesam
commented
Aug 31, 2021
tests/server_test.go
Outdated
| assert.Equal(t, 403, resp.StatusCode) | ||
| body, err = ioutil.ReadAll(resp.Body) | ||
| require.NoError(t, err) | ||
| assert.Equal(t, `{"error":"Flux query service disabled. Verify flux-enabled=true in the [http] section of the InfluxDB config."}` + "\n", string(body)) |
There was a problem hiding this comment.
Previously this was plaintext instead of json
lesam
commented
Aug 31, 2021
| func (m *mockPlanner) FullyCompacted() (bool, string) { return false, "not compacted" } | ||
| func (m *mockPlanner) ForceFull() {} | ||
| func (m *mockPlanner) SetFileStore(fs *tsm1.FileStore) {} | ||
| func (m *mockPlanner) PlanLevel(level int) ([]tsm1.CompactionGroup, int64) { return nil, 0 } |
There was a problem hiding this comment.
Looks like our formatting checks have some gaps...
lesam
force-pushed
the
fix-flux-error
branch
3 times, most recently
from
1af8aac to
97498d9
Compare
lesam
commented
Aug 31, 2021
| no_output_timeout: 1500s | ||
| - run: | ||
| name: Convert test output to junit | ||
| command: go-junit-report < tests.log > junit/influxdb.junit.xml |
There was a problem hiding this comment.
Fix to always report which tests actually failed (especially when a test actually does fail).
gwossum
approved these changes
Aug 31, 2021
lesam
added a commit
to lesam/influxdb
that referenced
this pull request
Sep 1, 2021
(cherry picked from commit 38de69c)
lesam
added a commit
to lesam/influxdb
that referenced
this pull request
Sep 1, 2021
(cherry picked from commit 38de69c)
lesam
added a commit
that referenced
this pull request
Sep 1, 2021
chengshiwen
pushed a commit
to chengshiwen/influxdb
that referenced
this pull request
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22327