Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hard limit on field size while parsing line protocol #22311

Merged
merged 5 commits into from
Aug 27, 2021

Conversation

danxmoran
Copy link
Contributor

Closes #22310

Forward-ports #21843, and adds a 2.x-specific CLI flag to influxd for the new config.

lesam and others added 2 commits August 26, 2021 11:15
Per https://docs.influxdata.com/influxdb/v2.0/reference/syntax/line-protocol/#string
we only support 64KB, but 1MB is a more realistic practical limit. Before this commit there was
no enforcement of field value size.
@danxmoran danxmoran requested a review from lesam August 26, 2021 15:27
@danxmoran danxmoran removed the request for review from lesam August 26, 2021 19:57
@lesam
Copy link
Contributor

lesam commented Aug 26, 2021

Worth a test for the force flag being set maybe? Or at least a manual test that everything is plumbed through correctly. For 1.x there's an Enterprise test that sets the config flag and ensures it works.

@danxmoran danxmoran requested a review from lesam August 26, 2021 21:04
@danxmoran danxmoran merged commit 4dd2d7c into master Aug 27, 2021
@danxmoran danxmoran deleted the dm-forward-port-lp-field-value-limit-22310 branch August 27, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[forward-port 2.x] Enforce a max field-value size for line protocol
2 participants