Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always notify term change on RequestVote. #2223

Merged
merged 1 commit into from
Apr 9, 2015
Merged

Conversation

benbjohnson
Copy link
Contributor

Overview

Previously there was a bug that ignored new terms from incoming vote requests when the sender's log was out of date. This fixes it so that new terms are saved even if the vote is rejected.

Previously there was a bug that ignored new terms from incoming vote
requests when the sender's log was out of date.
@otoolep
Copy link
Contributor

otoolep commented Apr 9, 2015

+1, makes sense to me.

benbjohnson added a commit that referenced this pull request Apr 9, 2015
Always notify term change on RequestVote.
@benbjohnson benbjohnson merged commit 8d11434 into master Apr 9, 2015
@benbjohnson benbjohnson deleted the req-vote-term-notify branch April 9, 2015 19:57
mark-rushakoff pushed a commit that referenced this pull request Jan 11, 2019
* Initial pass at Confirmation Delete component

* Require confirmation when deleting a dashboard

* Require confirmation when deleting a task

* Cleanup

* Write unit test

* Rewrite test to use jest mock function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants