Fix race condition on continuous queries #2203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 on green |
|
Are you talking about this change?
Is this what we need to lock? |
|
@otoolep correct. |
|
OK, thanks. That code actually seems problematic, though it is there now, and not actually being changed. Is |
|
No idea. I didn't look that closely at it, just that it was a race condition. @pauldix would know the answer. |
|
OK, makes sense if the race detector flagged. Definitely have a question about it for @pauldix |
corylanou
added a commit
that referenced
this pull request
Apr 9, 2015
Fix race condition on continuous queries
mark-rushakoff
pushed a commit
that referenced
this pull request
Jan 11, 2019
* chore(http): make test diffs more readable * fixes * add back telegraf output spacing * whitespace hell * jsonEqual2 -> jsonEqual
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need a
Lockinstead of anRLockas we are writing inside the loop.