fix: copy names from mmapped memory before closing iterator #21999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidby-influx
force-pushed
the
DSB_infor_panic
branch
from
0d1c83c to
c0c8a0c
Compare
lesam
reviewed
Aug 2, 2021
| @@ -1330,7 +1330,8 @@ func (is IndexSet) MeasurementNamesByExpr(auth query.FineAuthorizer, expr influx | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| return slices.CopyChunkedByteSlices(names, 1000), nil | |||
| // Requires that names is a copy of the names from the mmapped file | |||
| return names, nil | |||
There was a problem hiding this comment.
This seems quite different than before because we now allocate more memory for this part:
case influxql.OR, influxql.AND:
lhs, err := is.measurementNamesByPredicate(auth, e.LHS)
if err != nil {
return nil, err
}
rhs, err := is.measurementNamesByPredicate(auth, e.RHS)
if err != nil {
return nil, err
}
Also what about the Expr versions - e.g. measurementNamesByTagFilter ?
Ensure that when looking up measurement names all pointers to mmapped memory are copied to heap memory before the mmaped iterators are closed. Closes influxdata/EAR#2371
davidby-influx
force-pushed
the
DSB_infor_panic
branch
from
c0c8a0c to
2afed74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that when looking up measurement names all
pointers to mmapped memory are copied to heap memory
before the mmapped iterators are closed.
closes #22000