Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow http write handler to decode gzipped body #2180

Merged
merged 2 commits into from
Apr 7, 2015
Merged

Conversation

corylanou
Copy link
Contributor

Previously, we supported streaming out gzip'ed responses, but we had not implemented the ability to post gzipped json to our write endpoint.

@corylanou
Copy link
Contributor Author

Need to add an integration test, but we have a bash script for now to validate that it worked. Will add an integration test in a future PR. Need to get this merged for now.

@@ -485,6 +499,7 @@ func (h *Handler) serveWrite(w http.ResponseWriter, r *http.Request, user *influ
writeError(influxdb.Result{Err: err}, http.StatusInternalServerError)
return
} else {
w.WriteHeader(http.StatusOK)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we were ever returning 200 properly before, not sure how I didn't catch this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't call it at all, 200 is returned, right?

@otoolep
Copy link
Contributor

otoolep commented Apr 7, 2015

+1, assuming you ran the test script against the change, of course.

corylanou added a commit that referenced this pull request Apr 7, 2015
Allow http write handler to decode gzipped body
@corylanou corylanou merged commit fadcef0 into master Apr 7, 2015
@corylanou corylanou deleted the http-gzip-posts branch April 7, 2015 16:00
mark-rushakoff pushed a commit that referenced this pull request Jan 11, 2019
Add support for get /api/v2/query
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants